mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 68235: Cleaned up container on launch failures in composing containerizer.
Date Mon, 27 Aug 2018 14:57:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68235/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Gilbert Song, and Qian Zhang.


Summary (updated)
-----------------

Cleaned up container on launch failures in composing containerizer.


Repository: mesos


Description (updated)
-------

Previously, if a parent container was unknown to the composing
containerizer during an attempt to launch a nested container
via `ComposingContainerizerProcess::launch()`, the composing
containerizer returned an error without cleaning up the container.
The `containerizer` field was uninitialized, so a further attempt
to remove or destroy the nested container led to segfault.

This patch removes the container when the parent container is unknown.


Diffs (updated)
-----

  src/slave/containerizer/composing.cpp 521645839b422d455da08ce7ab306f83da0b88ad 


Diff: https://reviews.apache.org/r/68235/diff/1/


Testing (updated)
-------

sudo make check (Fedora 25)

This test fixes agent's segfault when running `AgentAPITest.LaunchNestedContainerWithUnknownParent`
test, which can be found in the previous patch.


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message