mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68442: Added '/frameworks' to the set of batched master endpoints.
Date Mon, 27 Aug 2018 11:19:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68442/#review207961
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp
Line 1690 (original), 1700 (patched)
<https://reviews.apache.org/r/68442/#comment291632>

    This seems inconsistent to other handlers you've introduced: you've been capturing `master`
there.



src/master/http.cpp
Line 1734 (original), 1744 (patched)
<https://reviews.apache.org/r/68442/#comment291629>

    `std::move`



src/master/master.hpp
Lines 1420-1424 (patched)
<https://reviews.apache.org/r/68442/#comment291651>

    let's keep 'em sorted



src/master/master.hpp
Line 1464 (original), 1469 (patched)
<https://reviews.apache.org/r/68442/#comment291630>

    // NOTE: Requests to this endpoint are batched.
    
    or grouping, see https://reviews.apache.org/r/68441/


- Alexander Rukletsov


On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68442/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2018, 1:16 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added '/frameworks' to the set of batched master endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 
> 
> 
> Diff: https://reviews.apache.org/r/68442/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message