mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Liangyu Zhao via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.
Date Sat, 25 Aug 2018 21:57:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67932/
-----------------------------------------------------------

(Updated Aug. 25, 2018, 9:57 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, Joseph
Wu, and Qian Zhang.


Repository: mesos


Description
-------

The `tar` command cannot work successfully on Windows, so we use
`wclayer` instead. Note that the folder generated from extraction also
cannot be deleted by `rmdir`, so the GC is also changed to use
`wclayer remove`.


Diffs (updated)
-----

  src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc 
  src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

  src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6



Diff: https://reviews.apache.org/r/67932/diff/11/

Changes: https://reviews.apache.org/r/67932/diff/10-11/


Testing
-------


Thanks,

Liangyu Zhao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message