mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.
Date Fri, 24 Aug 2018 23:26:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68401/
-----------------------------------------------------------

(Updated Aug. 24, 2018, 11:26 p.m.)


Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, and Jiang Yan Xu.


Bugs: MESOS-5158
    https://issues.apache.org/jira/browse/MESOS-5158


Repository: mesos


Description
-------

Added persistent volume support to the `disk/xfs` isolator. This
implementation largely tracks the `disk/du` implementation in that
we now keep a map of paths in each container info structure. We now
defer quota clean up to project ID reclaimation time so that we can
use the same mechanism for sandbox and persistent volume paths.

We explicitly exclude mount disks from XFS project quotas, but we still
track them so that we can correctly publish their usage information in
the container `DiskStatistics` message. This means that mount disks are
not required to be XFS filesystems or have project quotas configured.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 38c467b47cb7c04803b0709b8239458fb26abb61

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 783da0407528c044035d18cc59a744353921d64c

  src/tests/containerizer/xfs_quota_tests.cpp 59ec182c1c3af3978156044f03d9e3d784d51fce 


Diff: https://reviews.apache.org/r/68401/diff/2/

Changes: https://reviews.apache.org/r/68401/diff/1-2/


Testing
-------

sudo make check (Fedora 28)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message