mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 67930: Windows: Enabled `DockerFetcherPluginTest` suite.
Date Fri, 24 Aug 2018 05:51:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67930/#review207851
-----------------------------------------------------------




src/tests/uri_fetcher_tests.cpp
Lines 302-307 (patched)
<https://reviews.apache.org/r/67930/#comment291398>

    hum, i don't get this part. are you saying that even if we're asking for schema 1 manifest,
we'll get schema 2 manifest?



src/tests/uri_fetcher_tests.cpp
Lines 309-310 (original), 320-329 (patched)
<https://reviews.apache.org/r/67930/#comment291399>

    We can use a constant like `TEST_REPOSITORY` in the top of this file? lile `TEST_DIGEST`?


- Jie Yu


On Aug. 6, 2018, 6:46 p.m., Liangyu Zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67930/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2018, 6:46 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, Joseph
Wu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled `Internet` test environment on Windows. Disabled `Internet`
> `HealthCheckTests` on Windows, since they require complete
> development. Modified `DockerFetcherPluginTest` to fetch
> `microsoft/nanoserver` for more extensive test for fetcher on Windows.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 
>   src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638 
>   src/tests/uri_fetcher_tests.cpp 260ae9c96f78ee5528cbd61983e1d61bda48c23b 
> 
> 
> Diff: https://reviews.apache.org/r/67930/diff/7/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message