mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68493: Avoided unnecessary copies in `Resources::parse()`.
Date Fri, 24 Aug 2018 01:26:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68493/#review207846
-----------------------------------------------------------



Bad patch!

Reviews applied: [68493, 68490, 68489]

Failed command: python support/apply-reviews.py -n -r 68489

Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-08-24 01:26:57 URL:https://reviews.apache.org/r/68489/diff/raw/ [2534/2534] -> "68489.patch"
[1]
error: missing binary patch data for '3rdparty/boost-1.65.0.tar.gz'
error: binary patch does not apply to '3rdparty/boost-1.65.0.tar.gz'
error: 3rdparty/boost-1.65.0.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/23167/console

- Mesos Reviewbot


On Aug. 23, 2018, 10:14 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68493/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2018, 10:14 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Avoided unnecessary copies by iterating using references
> and using move when possible.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 0110c0ee3e810ad1c29dfa5507b13ebd5d0222a2 
>   src/v1/resources.cpp 228a7327ffe7934d37b56ee67b8be9ae1e119ca8 
> 
> 
> Diff: https://reviews.apache.org/r/68493/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message