mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Liangyu Zhao via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 68451: Windows: Parse version 2 schema 2 Docker image manifest.
Date Thu, 23 Aug 2018 22:44:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68451/
-----------------------------------------------------------

(Updated Aug. 23, 2018, 10:44 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, Joseph
Wu, and Qian Zhang.


Changes
-------

Unit tests added


Bugs: MESOS-9159
    https://issues.apache.org/jira/browse/MESOS-9159


Repository: mesos


Description
-------

Added support to parse V2S2 Docker image manifest
(https://docs.docker.com/registry/spec/manifest-v2-2/). Adopted the
validation code from patch 53850.


Diffs (updated)
-----

  include/mesos/docker/spec.hpp 2879414dc42ffe633ac74b51e1bb116698c41162 
  include/mesos/docker/v2_2.hpp PRE-CREATION 
  include/mesos/docker/v2_2.proto PRE-CREATION 
  src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb 
  src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
  src/docker/spec.cpp 96fbf1f9cf1c2c4b2383607a97990f3a9156e6d9 
  src/tests/CMakeLists.txt fd01531451c101280fbbe6f7eb62342bb70c1464 
  src/tests/containerizer/docker_spec_tests.cpp 8f2fa4e6ce222a212e4f71d6cbe6f9e29f52a07a 


Diff: https://reviews.apache.org/r/68451/diff/2/

Changes: https://reviews.apache.org/r/68451/diff/1-2/


Testing
-------


Thanks,

Liangyu Zhao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message