mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68420: Added regression test for encoded queries over the `/files` API.
Date Thu, 23 Aug 2018 20:02:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68420/#review207830
-----------------------------------------------------------



How about the following for commit summary and description:

```
Added /files API test for reserved query characters.

Due to a bug in the http client in libprocess (MESOS-9168), the
use of reserved query characters in paths did not work when using
the http client in libprocess. This adds a test to ensure that
the /files API correctly handles reserved query characters in
file paths.
```


src/tests/files_tests.cpp
Lines 323-325 (patched)
<https://reviews.apache.org/r/68420/#comment291357>

    How about:
    
    ```
    // Tests paths with reserved characters that must be percent
    // encoded in the http request query.
    ```



src/tests/files_tests.cpp
Lines 326 (patched)
<https://reviews.apache.org/r/68420/#comment291359>

    How about: `ReservedQueryCharacter`



src/tests/files_tests.cpp
Lines 331-332 (patched)
<https://reviews.apache.org/r/68420/#comment291358>

    This is a little odd to read without the context, this tests reserved characters by using
`%`, but we could use anything other reserved character to acheive the same test, e.g. `+`
seems the simplest:
    
    ```
      // We use a reserved character for query parameters `+` to
      // ensure it is encoded and decoded correctly.
      const string filename = "foo+bar";
    ```
    
    If you'd like to stick with using `%`, probably we should just say:
    
    ```
      // We use a reserved character for query parameters `%` to
      // ensure it is encoded and decoded correctly.
      const string filename = "foo%3Abar";
    ```
    
    And not do line 334 as it's irrelevant to this test


- Benjamin Mahler


On Aug. 18, 2018, 1:20 a.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68420/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2018, 1:20 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9168
>     https://issues.apache.org/jira/browse/MESOS-9168
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test currently fails with:
> 
> ```
> src\tests\files_tests.cpp(346): error: Value of: (response)->status
>   Actual: "404 Not Found"
> Expected: OK().status
> Which is: "200 OK"
>     Body: ""
> src\tests\files_tests.cpp(347): error: Value of: (response)->body
>   Actual: ""
> Expected: stringify(expected)
> Which is: "{\"data\":\"body\"}"
> ```
> 
> This is due to libprocess decoding the query in both `http::get()` and
> in the `DataDecoder`. However, libprocess only encodes once. When the
> user has a query with a literal ASCII escape sequence, it is expected
> that it should only need to be encoded once. That is `foo%3Abar`
> should be represented in the query as `foo%253Abar`. Because
> libprocess decodes twice, but currently only encodes once, this query
> erroneously becomes `foo:bar`. The added test demonstrates how this
> breaks something such as the `files` server.
> 
> 
> Diffs
> -----
> 
>   src/tests/files_tests.cpp d09279077ec704167991933349ee943ab44d0aa9 
> 
> 
> Diff: https://reviews.apache.org/r/68420/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message