mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 68484: Enforced disabling boost debug mode.
Date Thu, 23 Aug 2018 17:31:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68484/#review207821
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.hpp
Lines 31 (patched)
<https://reviews.apache.org/r/68484/#comment291345>

    Nit: s/version/versions/
    
    `slave.cpp` also includes `boost/circular_buffer.hpp`, we should do the same there.


- Gastón Kleiman


On Aug. 23, 2018, 9:25 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68484/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2018, 9:25 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-9177
>     https://issues.apache.org/jira/browse/MESOS-9177
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Always disable boost debug mode.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d 
> 
> 
> Diff: https://reviews.apache.org/r/68484/diff/1/
> 
> 
> Testing
> -------
> 
> * Compiled mesos master against boost 1.53 from https://downloads.mesosphere.com/pkgpanda-artifact-cache/boost_1_53_0.tar.gz.
> * Wrote a script that can trigger a segfault by reading from a circular buffer in parallel
(pasted in the linked ticket) and verified that it crashes mesos master.
> * Recompiled mesos with this patch applied.
> * Verified that the above script does not produce a segfault anymore.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message