mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 68484: Enforced disabling boost debug mode.
Date Thu, 23 Aug 2018 16:25:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68484/
-----------------------------------------------------------

(Updated Aug. 23, 2018, 4:25 p.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-9177
    https://issues.apache.org/jira/browse/MESOS-9177


Repository: mesos


Description (updated)
-------

Always disable boost debug mode.


Diffs
-----

  src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d 


Diff: https://reviews.apache.org/r/68484/diff/1/


Testing (updated)
-------

* Compiled mesos master against boost 1.53.
* Wrote a script that can trigger a segfault by reading from a circular buffer in parallel
(pasted in the linked ticket) and verified that it crashes mesos master.
* Recompiled mesos with this patch applied.
* Verified that the above script does not produce a segfault anymore.


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message