mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 68453: Windows: Fetch version 2 scheme 2 Docker image manifest.
Date Thu, 23 Aug 2018 05:52:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68453/#review207804
-----------------------------------------------------------




src/uri/fetchers/docker.cpp
Line 745 (original), 853-864 (patched)
<https://reviews.apache.org/r/68453/#comment291317>

    This is probably more clear if we just inline `__fetchBlob` here:
    
    ```
    if (code == http::Status::OK) {
      return Nothing();
    }
      
    #ifdef __WINDOWS__
    return urlFetchBlob(uri, directory, blobUri, authHeaders, code);
    #else
    return Failure(
        "Unexpected HTTP response '" + http::Status::string(code) + "' "
        "when trying to download the blob");
    #endif
    });
    ```



src/uri/fetchers/docker.cpp
Lines 774-776 (original), 893-908 (patched)
<https://reviews.apache.org/r/68453/#comment291316>

    I think this is probably more clear like the following:
    ```
    .then(defer(self(), [=](int code) {
      if (code == http::Status::OK) {
        return Nothing();
      }
      
    #ifdef __WINDOWS__
      return urlFetchBlob(uri, directory, blobUri, authHeaders, code);
    #else
      return Failure(
          "Unexpected HTTP response '" + http::Status::string(code) + "' "
          "when trying to download the blob");
    #endif
    });
    ```


- Jie Yu


On Aug. 21, 2018, 9:29 p.m., Liangyu Zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68453/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 9:29 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, Joseph
Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-9159
>     https://issues.apache.org/jira/browse/MESOS-9159
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> DockerFetcher now fetches both V2S1 and V2S2 manifests to save on
> disk when agent is running on Windows. Linux part of the code in
> agent is unchanged.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 55ca118660872a933a2dc186723bec6a39ee80f7 
> 
> 
> Diff: https://reviews.apache.org/r/68453/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message