mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 68068: Added tests for task metadata GC using the default executor.
Date Wed, 22 Aug 2018 18:33:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/
-----------------------------------------------------------

(Updated Aug. 22, 2018, 11:33 a.m.)


Review request for mesos, Gilbert Song and Qian Zhang.


Changes
-------

Rebase and change new tests to use `::testing::Sequence`.


Bugs: MESOS-7947
    https://issues.apache.org/jira/browse/MESOS-7947


Repository: mesos


Description
-------

This adds two tests that launch a long-lived and short-lived task
on the same executor.  The tests expect the short-lived task's
metadata and sandbox to be garbage collected.

One test restarts the agent before GC to ensure recovery will
schedule completed tasks for GC too.

One existing test is modified due to the extra GC event from
task metadata.


Diffs (updated)
-----

  src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421 
  src/tests/slave_recovery_tests.cpp 9710518db30ce3826284f3b7e323bdd9aa207831 


Diff: https://reviews.apache.org/r/68068/diff/3/

Changes: https://reviews.apache.org/r/68068/diff/2-3/


Testing
-------

make check (OSX)

(Other platforms pending...)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message