mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68472: Removed `ROOT` requirement some `StorageLocalResourceProvider` tests.
Date Wed, 22 Aug 2018 12:28:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68472/#review207742
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68472]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 22, 2018, 10:30 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68472/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2018, 10:30 a.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests required `ROOT` in order to use `filesystem/linux`
> isolation this is not a requirement anymore so we can run the tests in
> general. These tests appear to be able to run in parallel as well.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 9b88d366df958d938a3a0cac4f64a937c6178ee3

> 
> 
> Diff: https://reviews.apache.org/r/68472/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> `GTEST_FILTER='*StorageLocalResourceProviderTest*' ../support/mesos-gtest-runner.py ./src/mesos-tests`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message