mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68224: Augmented `Statistics` to work with any collection.
Date Wed, 22 Aug 2018 02:30:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68224/#review207724
-----------------------------------------------------------


Fix it, then Ship it!




Looks good!


3rdparty/libprocess/include/process/statistics.hpp
Lines 61-71 (patched)
<https://reviews.apache.org/r/68224/#comment291216>

    It would be great to send this to mpark on slack to get some feedback, as I'd love to
use it in many other places (e.g. process::collect/await). Looks ok to me though as is (albeit
a tough read!).



3rdparty/libprocess/include/process/statistics.hpp
Line 108 (original), 148 (patched)
<https://reviews.apache.org/r/68224/#comment291215>

    Whoops? Can you remove this stray from the diff?



3rdparty/libprocess/src/tests/statistics_tests.cpp
Lines 94-95 (patched)
<https://reviews.apache.org/r/68224/#comment291214>

    Nice!


- Benjamin Mahler


On Aug. 14, 2018, 12:48 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68224/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2018, 12:48 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/statistics.hpp e9f1fc23bf83f92a2e7de94dba0df48272cc3394

>   3rdparty/libprocess/src/tests/statistics_tests.cpp a2a780bf9de018c823b68aa48977fd9fd1b8a064

> 
> 
> Diff: https://reviews.apache.org/r/68224/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message