mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Liangyu Zhao via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 68174: Support for `wstring` in stout.
Date Wed, 22 Aug 2018 00:38:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68174/
-----------------------------------------------------------

(Updated Aug. 22, 2018, 12:38 a.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.


Repository: mesos


Description
-------

Use template to extend string support to wstring, mainly for Windows
environment. More information on this can be found in
`developer-guide.md`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/internal/windows/attributes.hpp 673b744588fee32aa4c462199be0675c392636fb

  3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45

  3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55

  3rdparty/stout/include/stout/os/windows/environment.hpp 40eee59ac0b73ebe71b120e540ba7eace672ff4c

  3rdparty/stout/include/stout/os/windows/getcwd.hpp daf131ac1da705724e85cd236c68685422d2f3c8

  3rdparty/stout/include/stout/os/windows/getenv.hpp 034510cff3701f1063c4fa7ff5c0acb63b421717

  3rdparty/stout/include/stout/os/windows/jobobject.hpp 7d6678ddedff5732698007fb4d745c37648b964c

  3rdparty/stout/include/stout/os/windows/ls.hpp 68d5a6037c4c73d6233829259e4fceb4db613a0c

  3rdparty/stout/include/stout/os/windows/mktemp.hpp b4f5279a58274f02b260bdb3b94c284547842a0f

  3rdparty/stout/include/stout/os/windows/realpath.hpp 6bfaaf63f849129793b5b3e2d501623ec83e9d4f

  3rdparty/stout/include/stout/os/windows/rmdir.hpp 00821cdb62a02824e26ddb125eca66694165ce1f

  3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78

  3rdparty/stout/include/stout/os/windows/su.hpp ac3a8968f7b9fe6889e13aa47595ae45a094c891

  3rdparty/stout/include/stout/os/windows/temp.hpp 4e8543ee6b67f0c2b50a858826e19eed211452bc

  3rdparty/stout/include/stout/path.hpp ef5a2f3d14cc8cf7416ded5cad00d30a49fd5cf7 
  3rdparty/stout/include/stout/stringify.hpp ef7b26fd30aff2e2554162bdd0370523306b5930 
  3rdparty/stout/include/stout/strings.hpp 1af3818dd9f906115cf067ca1eb2fb30f85a139d 
  3rdparty/stout/include/stout/windows/fs.hpp cc9a56012bd17cf962c8bc6d59ae221fcf19ecba 
  3rdparty/stout/include/stout/windows/net.hpp 74398637fe830af0655b1358d4ea52d259a97e9e 
  3rdparty/stout/include/stout/windows/os.hpp 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531 
  3rdparty/stout/tests/recordio_tests.cpp 177939427a7ef5f15cac318a98e40cf77b0b0ada 
  docs/developer-guide.md 3906275e18801853bd21da18073c9f0e44aba2cd 
  src/docker/executor.cpp f461af91c65fad904bdf7a9f0e6d95763b2b936c 
  src/slave/containerizer/mesos/launch.cpp 7193da0a094df3e441e185c62b3a0379a0bdc4a2 
  src/tests/common/recordio_tests.cpp 5dd68802ed385c3f7df39e2060bd1f087dbe8ef6 


Diff: https://reviews.apache.org/r/68174/diff/3/

Changes: https://reviews.apache.org/r/68174/diff/2-3/


Testing
-------


Thanks,

Liangyu Zhao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message