-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68461/#review207718
-----------------------------------------------------------
Fix it, then Ship it!
docs/upgrades.md
Line 463 (original), 458 (patched)
<https://reviews.apache.org/r/68461/#comment291212>
Nit: I'd wrap the type of volumes in backticks:
```
`HOST_PATH`, `SANDBOX_PATH`, `IMAGE`, `SECRET`, and `DOCKER_VOLUME`
```
docs/upgrades.md
Lines 467-471 (original), 462-468 (patched)
<https://reviews.apache.org/r/68461/#comment291211>
Nit I'd try to use indirect speach + past perfect to be consistent with the rest of the
document.
For example: To simplify the API for CSI-backed disk resources, the following operations
and corresponding ACLs have been introduced to replace the experimental
docs/upgrades.md
Lines 472 (patched)
<https://reviews.apache.org/r/68461/#comment291213>
s/has been added/flag has been added/
- Gastón Kleiman
On Aug. 21, 2018, 4:39 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68461/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 4:39 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added descriptions of new ACLs to `upgrades.md`.
>
>
> Diffs
> -----
>
> docs/upgrades.md ec9b3afa1dcba073815b5945aa9a1c32f64d43de
>
>
> Diff: https://reviews.apache.org/r/68461/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
|