mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 68458: Fixed the lib_logrotate inappropriate UNSET_CLOEXEC via ChildHook.
Date Tue, 21 Aug 2018 23:40:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68458/#review207715
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On Aug. 21, 2018, 10:03 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68458/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 10:03 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-9151
>     https://issues.apache.org/jira/browse/MESOS-9151
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, we call os::unsetCloexec() on write fd for both outfds and
> errfds. Basically, this is not needed because all stdout and stderr
> fds will be closed at childMain() method. As a result, no need to do
> unsetCloexec() either from the parent process side or UNSET_CLOEXEC
> via the ChildHook.
> 
> 
> Diffs
> -----
> 
>   src/slave/container_loggers/lib_logrotate.cpp 6a2839e07e0ea759ec16cb879ef0602341fd9f5c

> 
> 
> Diff: https://reviews.apache.org/r/68458/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message