mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <>
Subject Review Request 68458: Fixed the lib_logrotate inappropriate UNSET_CLOEXEC via ChildHook.
Date Tue, 21 Aug 2018 21:42:34 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Chun-Hung Hsiao, Jie Yu, and James Peach.

Repository: mesos


Previously, we call os::unsetCloexec() on write fd for both outfds and
errfds. Basically, this is not needed because all stdout and stderr
fds will be closed at childMain() method. As a result, no need to do
unsetCloexec() either from the parent process side or UNSET_CLOEXEC
via the ChildHook.


  src/slave/container_loggers/lib_logrotate.cpp 6a2839e07e0ea759ec16cb879ef0602341fd9f5c 



make check


Gilbert Song

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message