mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 68448: Skip the container if there's no container network.
Date Tue, 21 Aug 2018 20:24:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68448/#review207693
-----------------------------------------------------------


Ship it!




Ship It!

- Jiang Yan Xu


On Aug. 21, 2018, 12:16 p.m., Sergey Urbanovich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68448/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 12:16 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9171
>     https://issues.apache.org/jira/browse/MESOS-9171
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the container wants to join host network it won't have container
> networks. In that case `rootDir` could be not configured and
> `rootDir.get()` in `usage()` will cause mesos agent crash.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 6df52a55b13675df593872559b5238e8a10fd666

> 
> 
> Diff: https://reviews.apache.org/r/68448/diff/1/
> 
> 
> Testing
> -------
> 
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.VETH_VerifyResourceStatistics"
--gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message