mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 68443: Fixed the example for image_gc_config.
Date Tue, 21 Aug 2018 16:54:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68443/#review207671
-----------------------------------------------------------


Fix it, then Ship it!





docs/configuration/agent.md
Line 1016 (original), 1016 (patched)
<https://reviews.apache.org/r/68443/#comment291158>

    How are people reading the docs expected to find `flags.proto`?



docs/configuration/agent.md
Line 1023 (original), 1023 (patched)
<https://reviews.apache.org/r/68443/#comment291157>

    Can you add some expository text here?
    
    Maybe somee=thing like this
    ```
    In this example, image garbage collection is configured to sample disk usage every hour,
and will attempt to maintain at least 10% of free space on the container image filesystem:
    ```


- James Peach


On Aug. 21, 2018, 4:45 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68443/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2018, 4:45 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, James Peach, St├ęphane Cottin, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the unit is nanoseconds, setting it to 3600 is way too small, and
> misleading. This patch fixed the example to use 1 hour instead.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md bcddea2f8606f71fc46a39debca323d85c1d94c1 
>   src/slave/flags.cpp fd208f64416ae865b81c8ba5950b20bde6be00a3 
> 
> 
> Diff: https://reviews.apache.org/r/68443/diff/2/
> 
> 
> Testing
> -------
> 
> trivial
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message