mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 68378: Changed vector of requests to be mutable.
Date Tue, 21 Aug 2018 06:45:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68378/
-----------------------------------------------------------

(Updated Aug. 21, 2018, 6:45 a.m.)


Review request for mesos.


Bugs: MESOS-9158
    https://issues.apache.org/jira/browse/MESOS-9158


Repository: mesos


Description
-------

Changed the `batchedRequest` vector inside the `Master::Http`
class to be mutable, in order to be able to restore the
`const` qualifier to the `/state`-handler.

While this may be a debatable benefit for this
endpoint alone, the subsequent commits introduce
additional work to extend this mechanism to all
read-only endpoint of `Master`.

Without this change, this would create a paradoxical
situation where all mutating endpoints are marked as
const and all read-only endpoints are marked as
non-const.


Diffs
-----

  src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 
  src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d 


Diff: https://reviews.apache.org/r/68378/diff/2/


Testing (updated)
-------

See https://reviews.apache.org/r/68296/


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message