mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68321: Add '/state-summary' to batched master endpoints.
Date Tue, 21 Aug 2018 06:27:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207650
-----------------------------------------------------------




src/master/master.hpp
Lines 1401-1404 (original), 1401-1410 (patched)
<https://reviews.apache.org/r/68321/#comment291086>

    How about moving definitions on this class's methods to a separate file, e.g., "readonly_handlers.cpp"?


- Alexander Rukletsov


On Aug. 17, 2018, 7:03 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2018, 7:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add '/state-summary' to batched master endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 
>   src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d 
> 
> 
> Diff: https://reviews.apache.org/r/68321/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message