mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68296: Added 'handler' field to batched requests.
Date Tue, 21 Aug 2018 06:07:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/#review207649
-----------------------------------------------------------


Fix it, then Ship it!





src/master/http.cpp
Line 2861 (original), 2865 (patched)
<https://reviews.apache.org/r/68296/#comment291085>

    I think we don't add a space between the variable name and c-tor initialization list.


- Alexander Rukletsov


On Aug. 20, 2018, 2:11 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68296/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds a handler field to be able to batch
> arbitrary requests, instead of having a hard-coded
> dispatch to `state`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 
>   src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3 
> 
> 
> Diff: https://reviews.apache.org/r/68296/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message