mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68343: Moved state serialization into separate function.
Date Tue, 21 Aug 2018 06:02:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68343/#review207648
-----------------------------------------------------------


Ship it!




I'll do the last tweaks and commit this for you.


src/master/http.cpp
Line 2874 (original), 2874 (patched)
<https://reviews.apache.org/r/68343/#comment291084>

    Let's move the difinition around to follow the flow in .hpp. Alternatively we can also
put them all, say, in "master/readonly_handler.cpp". What'd you say?



src/master/master.hpp
Lines 1388-1389 (patched)
<https://reviews.apache.org/r/68343/#comment291083>

    We have an unwritten agreement to add a black line between paragraphs in comments.


- Alexander Rukletsov


On Aug. 20, 2018, 6:34 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68343/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2018, 6:34 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In preparation for the changes in the subsequent commit,
> the serialization logic was moved from an inner lambda
> to a separate function.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 
>   src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3 
> 
> 
> Diff: https://reviews.apache.org/r/68343/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message