mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68431: Made an operation reconciliation test more robust.
Date Mon, 20 Aug 2018 23:03:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68431/#review207641
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68431]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 20, 2018, 9:09 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68431/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2018, 9:09 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8872
>     https://issues.apache.org/jira/browse/MESOS-8872
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `OperationReconciliationTest.AgentPendingOperationAfterMasterFailover`
> is currently flaky on slow machines.
> 
> This patch temporarily resumes the clock after the master failover and
> until the agent reregisters. This should avoid deadlocks and make the
> test reliable.
> 
> 
> Diffs
> -----
> 
>   src/tests/operation_reconciliation_tests.cpp aec298d76d971219e1cbecd33ffd24b4af9d0484

> 
> 
> Diff: https://reviews.apache.org/r/68431/diff/1/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter='*AgentPendingOperationAfterMasterFailover*' --verbose
--gtest_repeat=1000 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message