mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 68329: Windows: Made `libwinio` the default option.
Date Mon, 20 Aug 2018 22:11:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68329/
-----------------------------------------------------------

(Updated Aug. 20, 2018, 3:11 p.m.)


Review request for mesos, Akash Gupta, Benjamin Mahler, and Joseph Wu.


Changes
-------

Added missing depedency (post-reviews on Windows is weird sometimes still).


Bugs: MESOS-9084
    https://issues.apache.org/jira/browse/MESOS-9084


Repository: mesos


Description
-------

Note that we now add `io_tests.cpp` unconditionally, which will
fail/hang with libevent. However, this is because libevent is buggy,
and should not be used. We would prefer the tests not pass with
libevent enabled, rather than appear to pass because the failing tests
are excluded, giving the false impression that it works correctly.


Diffs
-----

  3rdparty/libprocess/src/CMakeLists.txt 19fa9809c2298ea68649702b94a0c75d806caba3 
  3rdparty/libprocess/src/tests/CMakeLists.txt a03a77eb5e289b4daac0bbd414dc17c8acc848dc 


Diff: https://reviews.apache.org/r/68329/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message