mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 68396: Updated the ::pipe() system calls to pipe2 in posix subprocess.
Date Mon, 20 Aug 2018 19:04:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68396/#review207629
-----------------------------------------------------------




3rdparty/libprocess/src/posix/subprocess.cpp
Line 66 (original), 68 (patched)
<https://reviews.apache.org/r/68396/#comment291075>

    Oh that's a lot cleaner than `.get()[0]`... gotta go fix Windows now. Though you can replace
the declaration + assignments with just:
    
    `return OutputFileDescriptors{pipefd->at(0), pipefd->at(1)};` and then (after I
use `at`) it'll look just like windows/subprocess.cpp!
    
    Actually... it would end up identical save for the arguments sent to `os::pipe`. Time
for some consolidation?


- Andrew Schwartzmeyer


On Aug. 17, 2018, 3:36 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68396/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2018, 3:36 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Jie
Yu, James Peach, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the ::pipe() system calls to pipe2 in posix subprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/posix/subprocess.cpp 01e3272fccda6ff66e1629fb10d22d8c4967b22a

> 
> 
> Diff: https://reviews.apache.org/r/68396/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message