mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 68319: Put binaries into root folder in libprocess.
Date Mon, 20 Aug 2018 18:18:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68319/#review207624
-----------------------------------------------------------



I have to ask: why? I've personally thought it would be nicer to remove this rather unexpected
logic (from a CMake standpoint) from Mesos. Why add it to stout and libprocess?

- Andrew Schwartzmeyer


On Aug. 20, 2018, 2:53 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68319/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2018, 2:53 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Put binaries into root folder in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/CMakeLists.txt 5bba8e2c59ea3d7c37d186a2273bcaad6ffb5c46 
>   3rdparty/libprocess/src/tests/CMakeLists.txt a03a77eb5e289b4daac0bbd414dc17c8acc848dc

> 
> 
> Diff: https://reviews.apache.org/r/68319/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message