mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 68343: Moved state serialization into separate function.
Date Mon, 20 Aug 2018 14:12:57 GMT


> On Aug. 20, 2018, 9:43 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Line 3031 (original), 3030-3031 (patched)
> > <https://reviews.apache.org/r/68343/diff/2/?file=2074712#file2074712line3039>
> >
> >     Is pass-by-value intentional?

I think it is required by `async()`, but I'll need to double-check.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68343/#review207605
-----------------------------------------------------------


On Aug. 20, 2018, 2:08 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68343/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2018, 2:08 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In preparation for the changes in the subsequent commit,
> the serialization logic was moved from an inner lambda
> to a separate function.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 
>   src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3 
> 
> 
> Diff: https://reviews.apache.org/r/68343/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message