mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 68296: Added 'handler' field to batched requests.
Date Mon, 20 Aug 2018 14:11:42 GMT


> On Aug. 20, 2018, 9:51 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Line 3031 (original), 3035-3036 (patched)
> > <https://reviews.apache.org/r/68296/diff/6/?file=2074729#file2074729line3035>
> >
> >     These will become `const &`.

Huh, weird, this looks like another reviewboard-bug - it's changed to `const &` in the
dependent review `r/68343` yet this one show "no change" but also doesn't show the correct
state of this line.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/#review207606
-----------------------------------------------------------


On Aug. 20, 2018, 2:11 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68296/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds a handler field to be able to batch
> arbitrary requests, instead of having a hard-coded
> dispatch to `state`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 
>   src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3 
> 
> 
> Diff: https://reviews.apache.org/r/68296/diff/7/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message