-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68360/#review207561
-----------------------------------------------------------
PASS: Mesos patch 68360 was successfully built and tested.
Reviews applied: `['68360']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2190/mesos-review-68360
- Mesos Reviewbot Windows
On Aug. 17, 2018, 7:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68360/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 7:02 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> After creation on an `ObjectApprovers` instance, the principal
> is only required for providing meaningful log messages.
>
> This commit encodes that at the type system by storing the principal
> as a string as opposed to a `Principal` object.
>
>
> Diffs
> -----
>
> src/common/http.hpp 0901a5528b3c383e3e391a3ac1571fd0fd544998
>
>
> Diff: https://reviews.apache.org/r/68360/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
|