mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 63280: Made the containerizer launch be explicit about O_CLOEXEC.
Date Fri, 17 Aug 2018 18:14:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63280/
-----------------------------------------------------------

(Updated Aug. 17, 2018, 6:14 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Gilbert
Song, Greg Mann, and Jie Yu.


Bugs: MESOS-8128
    https://issues.apache.org/jira/browse/MESOS-8128


Repository: mesos


Description
-------

Since the containerizer launch depends on the inherited pipe to signal
the forked child, be explicit about manipulating O_CLOEXEC on the pipe
file descriptors. Make sure to close the pipe on the error paths.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a

  src/slave/containerizer/mesos/launcher.cpp ed41a14892bdfa74d28bd0541ca188b86f8f96f8 
  src/slave/containerizer/mesos/linux_launcher.cpp d1f8d3f56a9ef3aa98012c9395e74732e49c264d



Diff: https://reviews.apache.org/r/63280/diff/4/

Changes: https://reviews.apache.org/r/63280/diff/3-4/


Testing
-------

sudo make check (Fedora 28)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message