mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 63270: Updated `os::pipe()` to always return O_CLOEXEC descriptors.
Date Fri, 17 Aug 2018 17:53:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63270/
-----------------------------------------------------------

(Updated Aug. 17, 2018, 5:53 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin Mahler, Greg Mann,
and Jie Yu.


Changes
-------

rebased


Bugs: MESOS-8128
    https://issues.apache.org/jira/browse/MESOS-8128


Repository: mesos


Description
-------

Updated `os::pipe()` to always return O_CLOEXEC descriptors,
atomically if we are on Linux or FreeBSD and the `pipe2(2)`
system call is available.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/posix/pipe.hpp ac76224ff8fa1cc535c78731580e77a27967136a



Diff: https://reviews.apache.org/r/63270/diff/4/

Changes: https://reviews.apache.org/r/63270/diff/3-4/


Testing
-------

make check (Fedora 25)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message