mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68143: Made resource provider manager emit an event when provider subscribed.
Date Fri, 17 Aug 2018 13:57:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68143/
-----------------------------------------------------------

(Updated Aug. 17, 2018, 3:57 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
-------

Moved incorrectly squashed change from later in the chain here.


Bugs: MESOS-8403
    https://issues.apache.org/jira/browse/MESOS-8403


Repository: mesos


Description
-------

This patch adds a `SUBSCRIBE` resource provider message which is
emitted by the resource provider manager when a resource provider
subscribes. This event can e.g., be used to detect subscriptions when
theresource provider never updates any resources.

We currently do not expose this event from the agent outwards.


Diffs (updated)
-----

  src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620 
  src/resource_provider/message.hpp 9307f8859035dfafe0952e9026b078b44121537e 
  src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c 
  src/tests/resource_provider_manager_tests.cpp 0b9e985cf3b4ded8590615b418e52a2a11f1c1aa 


Diff: https://reviews.apache.org/r/68143/diff/3/

Changes: https://reviews.apache.org/r/68143/diff/2-3/


Testing
-------

`make check`

Additional testing with the test case added in https://reviews.apache.org/r/68147/.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message