mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68393: Fixed grpc compilation for directory paths with symlinks.
Date Thu, 16 Aug 2018 21:58:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68393/#review207439
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On Aug. 16, 2018, 8:15 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68393/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2018, 8:15 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Automake variable `abs_builddir` doesn't resolve symlinks so we
> explicitly call `realpath` on grpc targets.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 248d517874c2b34e98446d1e6724078c5c21708c 
> 
> 
> Diff: https://reviews.apache.org/r/68393/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message