mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.
Date Thu, 16 Aug 2018 20:46:37 GMT


> On Aug. 16, 2018, 12:24 p.m., Benjamin Mahler wrote:
> > src/sched/flags.hpp
> > Lines 122-125 (original), 122-125 (patched)
> > <https://reviews.apache.org/r/68346/diff/3/?file=2073291#file2073291line122>
> >
> >     Either in this review or the next one, we can rename to min and use a deprecated
alias for this old name:
> >     
> >     E.g.
> >     
> >     https://github.com/apache/mesos/blob/1.6.1/src/slave/flags.cpp#L441

Will do in the next review.


> On Aug. 16, 2018, 12:24 p.m., Benjamin Mahler wrote:
> > src/sched/sched.cpp
> > Lines 53 (patched)
> > <https://reviews.apache.org/r/68346/diff/3/?file=2073292#file2073292line53>
> >
> >     Actually, Future::after doesn't need this include, did you use the free-standing
after?

Removed.


> On Aug. 16, 2018, 12:24 p.m., Benjamin Mahler wrote:
> > src/sched/sched.cpp
> > Lines 425-426 (patched)
> > <https://reviews.apache.org/r/68346/diff/3/?file=2073292#file2073292line425>
> >
> >     Any reason not to use the same indentation as the agent logic here?

Both are formatted by the formater. Here we are more indented to start with comparing to the
agent. Thus we can not have the same indentation.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68346/#review207424
-----------------------------------------------------------


On Aug. 16, 2018, 1:46 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68346/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2018, 1:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9147
>     https://issues.apache.org/jira/browse/MESOS-9147
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixed the backoff time calculation
> overflow bug described in MESOS-9147.
> 
> The old approach times out an authentication request after
> `flags.authentication_timeout` and then retries after some
> backoff time. This is not optimal because, if the scheduler
> is going to backoff some time before retry, we might as well
> wait that long for the previous authentication request
> (instead of timeout early).
> 
> This patch combines the authentication timeout and
> authentication retry backoff interval into a single
> wait time interval. Now scheduler will timeout the previous
> authentication request after the wait time interval and
> then immediately retry.
> 
> 
> Diffs
> -----
> 
>   src/sched/constants.hpp 9edb25b38ba8e7e1dbbb4ce4c957bb6bd9f4af81 
>   src/sched/flags.hpp 2492665d44c424ff9f4f73c796520ebc51abbdff 
>   src/sched/sched.cpp 4de76225c73c9c17904512f5a72303d93ec915a7 
> 
> 
> Diff: https://reviews.apache.org/r/68346/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message