mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68144: Added methods to remove resource providers from provider manager.
Date Thu, 16 Aug 2018 14:31:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68144/
-----------------------------------------------------------

(Updated Aug. 16, 2018, 4:31 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
-------

Removed `TODO`.


Bugs: MESOS-8403
    https://issues.apache.org/jira/browse/MESOS-8403


Repository: mesos


Description
-------

This patch adds a method to remove a resource provider from the
resource provider manager. The resource provider will be marked as
removed in the manager's registry and disconnected. We also expose a
new `REMOVE` event whenever a resource provider was removed.

This patch does not add integration with e.g., the agent.


Diffs (updated)
-----

  src/resource_provider/manager.hpp 6c57956f0ec51820bfbe78e7fa213af2352b5a7f 
  src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620 
  src/resource_provider/message.hpp 9307f8859035dfafe0952e9026b078b44121537e 
  src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c 
  src/tests/resource_provider_manager_tests.cpp 0b9e985cf3b4ded8590615b418e52a2a11f1c1aa 


Diff: https://reviews.apache.org/r/68144/diff/3/

Changes: https://reviews.apache.org/r/68144/diff/2-3/


Testing
-------

`make check`

Additional testing with the test case added in https://reviews.apache.org/r/68147/.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message