mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.
Date Thu, 16 Aug 2018 12:19:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68354/#review207401
-----------------------------------------------------------



Bad patch!

Reviews applied: [68354, 68324, 68304]

Failed command: python support/apply-reviews.py -n -r 68354

Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-08-16 12:19:34 URL:https://reviews.apache.org/r/68354/diff/raw/ [6732/6732] -> "68354.patch"
[1]
error: patch failed: src/tests/authentication_tests.cpp:392
error: src/tests/authentication_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/23094/console

- Mesos Reviewbot


On Aug. 16, 2018, 12:06 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68354/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2018, 12:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the agent backs-off properly when
> retrying authentication according to the configured parameters.
> 
> Also mocked `Slave::authenticate()` for this test.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 802d4eb9e9eba2f1175dd85e56dcc80a61e32f74 
>   src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9 
>   src/tests/mock_slave.hpp 9a74bf35d2cab0a72ba6376392239d8080a49304 
>   src/tests/mock_slave.cpp 94a5b0d20475f49dde99108a009682b520175aa4 
> 
> 
> Diff: https://reviews.apache.org/r/68354/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> Added test continuously running without failure.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message