mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <>
Subject Review Request 68378: Changed vector of requests to be mutable.
Date Thu, 16 Aug 2018 12:07:03 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos.

Repository: mesos


Changed the `batchedRequest` vector inside the `Master::Http`
class to be mutable, in order to be able to restore the
`const` qualifier to the `/state`-handler.

While this may be a debatable benefit for this
endpoint alone, the subsequent commits introduce
additional work to extend this mechanism to all
read-only endpoint of `Master`.

Without this change, this would create a paradoxical
situation where all mutating endpoints are marked as
const and all read-only endpoints are marked as


  src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 
  src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d 




Benno Evers

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message