mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68355: Added a CNI test for networking statistics.
Date Thu, 16 Aug 2018 08:02:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review207393
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68052, 68053, 68054, 68355]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 15, 2018, 7:06 p.m., Sergey Urbanovich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2018, 7:06 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
>     https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp cb22e73b4215b5b0a49ac610e5f657b73d38963b

> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/3/
> 
> 
> Testing
> -------
> 
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics"
--gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message