mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 68361: Properly defer'ed calls to SLRP's `fatal` method.
Date Wed, 15 Aug 2018 23:01:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68361/#review207375
-----------------------------------------------------------



PASS: Mesos patch 68361 was successfully built and tested.

Reviews applied: `['68361']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2164/mesos-review-68361

- Mesos Reviewbot Windows


On Aug. 15, 2018, 1:47 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68361/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2018, 1:47 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9156
>     https://issues.apache.org/jira/browse/MESOS-9156
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `StorageLocalResourceProviderProcess::fatal` causes termination of the
> process' driver process via destruction of the driver process'
> wrapper. The wrapper correctly makes sure to `wait` for the process to
> finish. Due to the `wait` we must never call `fatal` on the driver
> process actor itself as otherwise the `wait` would deadlock.
> 
> This patch adds missing `defer`s so `fatal` is executed on the SLRP
> actor instead of an arbitrary actor, like e.g., the driver process
> actor.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e

> 
> 
> Diff: https://reviews.apache.org/r/68361/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message