mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68143: Made resource provider manager emit an event when provider subscribed.
Date Tue, 14 Aug 2018 23:43:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68143/#review207266
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/manager.cpp
Lines 801-802 (patched)
<https://reviews.apache.org/r/68143/#comment290604>

    Alternatively we could do the following, as the same as what we construct `updateState`:
    ```
    ResourceProviderMessage::Subscribe subscribe{resourceProvider->info};
    ```
    
    No strong preference though.



src/resource_provider/message.hpp
Line 63 (original), 71 (patched)
<https://reviews.apache.org/r/68143/#comment290600>

    It seems to me that once we process `SUBSCRIBE` in the agent, we could consider changing
`UpdateState::info` to `UpdateState::resourceProviderId`.



src/tests/resource_provider_manager_tests.cpp
Lines 260-264 (patched)
<https://reviews.apache.org/r/68143/#comment290607>

    Let's move this downwards to keep the the http-related assertions at the same place, and
keep
    ```
    EXPECT_FALSE(resourceProviderId->value().empty());
    ```



src/tests/resource_provider_manager_tests.cpp
Lines 355-359 (patched)
<https://reviews.apache.org/r/68143/#comment290609>

    Ditto.


- Chun-Hung Hsiao


On Aug. 1, 2018, 3:47 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68143/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2018, 3:47 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8403
>     https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a `SUBSCRIBE` resource provider message which is
> emitted by the resource provider manager when a resource provider
> subscribes. This event can e.g., be used to detect subscriptions when
> the resource provider never updates any resources.
> 
> We currently do not expose this event from the agent outwards.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620 
>   src/resource_provider/message.hpp 9307f8859035dfafe0952e9026b078b44121537e 
>   src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591 
>   src/tests/resource_provider_manager_tests.cpp 0b9e985cf3b4ded8590615b418e52a2a11f1c1aa

> 
> 
> Diff: https://reviews.apache.org/r/68143/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message