mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.
Date Fri, 10 Aug 2018 00:37:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68088/#review207052
-----------------------------------------------------------


Fix it, then Ship it!




Please modify the agent.md


src/slave/flags.cpp
Lines 541 (patched)
<https://reviews.apache.org/r/68088/#comment290237>

    Hey Zhitao, this patch looks good to me. I was thinking about what is the better default
semantic: hanging forever VS extend the timeout. I think for now, Let's do not change the
default behavior and set the default value as 60 seconds. You guys could configure the flag
to be longer (I would suggest forever).


- Gilbert Song


On July 30, 2018, 10:50 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68088/
> -----------------------------------------------------------
> 
> (Updated July 30, 2018, 10:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-8038
>     https://issues.apache.org/jira/browse/MESOS-8038
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new agent flag can be used to reconfigure how long a container
> destroy is allowed to take on Mesos containerizer.
> 
> The default is also increased to 5 min based on suggestion from Gilbert
> because certain containers could have deep system calls which may not
> finish within previous 1 min timeout.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 6a6f0e6df208bc0b0a888d132b3befd062755851 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed

>   src/slave/containerizer/mesos/linux_launcher.cpp 3bddcece7028745cec6623ac33dbfcaced629629

>   src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
>   src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 
> 
> 
> Diff: https://reviews.apache.org/r/68088/diff/2/
> 
> 
> Testing
> -------
> 
> `make` and `./bin/mesos-slave.sh --help`
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message