mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 68175: Windows: Change strings in Windows os code to `wstring`.
Date Wed, 08 Aug 2018 01:27:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68175/#review206963
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68174, 68175]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 2, 2018, 9:31 p.m., Liangyu Zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68175/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2018, 9:31 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Functions in `stout/internal/windows` and `stout/os/windows` now use
> `std::wstring` instead of `std::string`. Narrow string is still
> supported, but will converted to wide string for process. The return
> values for functions are unchanged.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/internal/windows/attributes.hpp 673b744588fee32aa4c462199be0675c392636fb

>   3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45

>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 280956ff9cfb0efcc5b0aa7ef35473122d9dd8c0

>   3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55

>   3rdparty/stout/include/stout/os/constants.hpp f81dbb3b7dcd929475324047f32cbabd873bea81

>   3rdparty/stout/include/stout/os/windows/chdir.hpp 523c7f75bd120b00f815c4c4aac946fdb5dbaaa5

>   3rdparty/stout/include/stout/os/windows/copyfile.hpp 34723bce9a151582de481d63a865509d4d29c02c

>   3rdparty/stout/include/stout/os/windows/exists.hpp 50bb92a1e4100a89a346d6bafc6d4133e6e40589

>   3rdparty/stout/include/stout/os/windows/getcwd.hpp daf131ac1da705724e85cd236c68685422d2f3c8

>   3rdparty/stout/include/stout/os/windows/getenv.hpp 034510cff3701f1063c4fa7ff5c0acb63b421717

>   3rdparty/stout/include/stout/os/windows/ls.hpp 68d5a6037c4c73d6233829259e4fceb4db613a0c

>   3rdparty/stout/include/stout/os/windows/mkdir.hpp 2aef22a47a80eddc9db0cd4e4ae3daf77c52c05b

>   3rdparty/stout/include/stout/os/windows/mkdtemp.hpp f742f0838cdc5132286f55775ca042ce8057c166

>   3rdparty/stout/include/stout/os/windows/mktemp.hpp b4f5279a58274f02b260bdb3b94c284547842a0f

>   3rdparty/stout/include/stout/os/windows/open.hpp b2f033c19027144083dc02cf3d4081b1fb26b501

>   3rdparty/stout/include/stout/os/windows/realpath.hpp 6bfaaf63f849129793b5b3e2d501623ec83e9d4f

>   3rdparty/stout/include/stout/os/windows/rename.hpp 523912ac3bf315f70f542e8eab7d2d02249909b4

>   3rdparty/stout/include/stout/os/windows/rm.hpp 2cacb28ec534e0f3e213d04ddf56168bc2061901

>   3rdparty/stout/include/stout/os/windows/rmdir.hpp 00821cdb62a02824e26ddb125eca66694165ce1f

>   3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78

>   3rdparty/stout/include/stout/os/windows/stat.hpp 62256094b9a58779e28dd78f1281a7d8bd7955d0

>   3rdparty/stout/include/stout/os/windows/su.hpp ac3a8968f7b9fe6889e13aa47595ae45a094c891

>   3rdparty/stout/include/stout/os/windows/temp.hpp 4e8543ee6b67f0c2b50a858826e19eed211452bc

>   3rdparty/stout/include/stout/windows/net.hpp 74398637fe830af0655b1358d4ea52d259a97e9e

>   3rdparty/stout/include/stout/windows/os.hpp 4f26806e4e027c090c6e7ce07b1bb8d2dabfb531

> 
> 
> Diff: https://reviews.apache.org/r/68175/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message