mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 68176: Fixed gRPC release build on Windows.
Date Fri, 03 Aug 2018 12:58:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68176/#review206841
-----------------------------------------------------------


Fix it, then Ship it!




LGTM!

Note that this shouldn't just fix Windows builds, but builds for any multiconfig generators
(e.g., xcode). Not sure xcode presently works, but you could reflect that in the commit message.


3rdparty/CMakeLists.txt
Line 1254 (original), 1254 (patched)
<https://reviews.apache.org/r/68176/#comment289935>

    This patch should land before https://reviews.apache.org/r/68091/ or https://reviews.apache.org/r/68074/.


- Benjamin Bannier


On Aug. 3, 2018, 1:06 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68176/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2018, 1:06 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Joseph Wu.
> 
> 
> Bugs: MESOS-8395
>     https://issues.apache.org/jira/browse/MESOS-8395
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The gRPC library was by default built by CMake with the "Debug"
> configuration on Windows, even if Mesos is built with the "Release"
> configuration. As a result, gRPC would try to link to the "Debug"
> protobuf library and end up with a failure. This patch fixes this
> problem by explicitly specifying the configuration in gRPC's build
> command.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916 
> 
> 
> Diff: https://reviews.apache.org/r/68176/diff/1/
> 
> 
> Testing
> -------
> 
> Built and tested using VS on Windows
> Built and tested using VS on Windows with `--config Release`
> Built and tested using Ninja on Linux
> Built and tested using Makefile on Linux
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message