mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 68166: Moved around some functions definitions between files.
Date Thu, 02 Aug 2018 14:49:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68166/#review206801
-----------------------------------------------------------



PASS: Mesos patch 68166 was successfully built and tested.

Reviews applied: `['68141', '68166']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2031/mesos-review-68166

- Mesos Reviewbot Windows


On Aug. 2, 2018, 6:23 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68166/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2018, 6:23 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit contains some fixups to the movement of the Framework
> implementation code to a separate file in the previous commit.
> 
>  * Changed Framework::send() to use an out-of-class definition.
>  * Moved back trivial functions back to the header file.
>  * Moved private constructor to the top of the file in `framework.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/master/framework.cpp PRE-CREATION 
>   src/master/master.hpp 45ffedbc314941f44a5330e78cf7dd2e402c9116 
> 
> 
> Diff: https://reviews.apache.org/r/68166/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message