mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 68152: Added missing iptables argument in CNI port mapper.
Date Thu, 02 Aug 2018 00:46:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68152/
-----------------------------------------------------------

(Updated Aug. 2, 2018, 12:46 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-9125
    https://issues.apache.org/jira/browse/MESOS-9125


Repository: mesos


Description (updated)
-------

Previously, the CNI port mapper was using the `-w` option in all
invocations of `iptables` except one. This option ensures that if
an application is currently holding the xtables lock, then `iptables`
will wait for the lock to be released and then continue execution.
Without setting the `-w` option, `iptables` will fail immediately if
the lock is currently held.

This patch adds the missing `-w` option to the port mapper code.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
c40b57f78193520f9f0b901201b5c4c855cde8b3 


Diff: https://reviews.apache.org/r/68152/diff/1/


Testing
-------


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message