mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68074: Always build gRPC in Mesos.
Date Wed, 01 Aug 2018 21:56:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68074/
-----------------------------------------------------------

(Updated Aug. 1, 2018, 9:56 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Addressed Benjamin's comments; merged with r68092.


Summary (updated)
-----------------

Always build gRPC in Mesos.


Bugs: MESOS-8395
    https://issues.apache.org/jira/browse/MESOS-8395


Repository: mesos


Description (updated)
-------

Always build gRPC in Mesos.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt d8d113c17d124b763659dcc5ace9066499de6cd4 
  3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339 
  cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa 
  configure.ac 58003b6e823c8457f4b5a8c8d670be43bf96de8d 
  include/csi/spec.hpp 2e9b870617a6604e5d3e93eedce119ec029eea05 
  src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
  src/Makefile.am 71f9052f60fc65d8183faa7ab9764d3e6388ddc9 
  src/cmake/MesosProtobuf.cmake 9fadc9f0616a00f3c30c1fa81a44e0023ccf865f 
  src/examples/CMakeLists.txt 6a6ee7c3029552ef12726d1c36ccabd8c79ba1f8 
  src/python/native_common/ext_modules.py.in dc4d91a8b8e3640e2191a53e657a5e4588fa911e 
  src/resource_provider/local.cpp ae23c2000b7941aad92d3b83e4e905bdf042ebe8 
  src/tests/CMakeLists.txt 695b6f543847d4270f7004a1768919904975d7a4 


Diff: https://reviews.apache.org/r/68074/diff/3/

Changes: https://reviews.apache.org/r/68074/diff/2-3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message