mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 68114: Fixed gRPC compilation with Clang when building Mesos.
Date Wed, 01 Aug 2018 21:49:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68114/
-----------------------------------------------------------

(Updated Aug. 1, 2018, 9:49 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Addressed Benjamin's comments.


Summary (updated)
-----------------

Fixed gRPC compilation with Clang when building Mesos.


Bugs: MESOS-8395
    https://issues.apache.org/jira/browse/MESOS-8395


Repository: mesos


Description
-------

When compiling gRPC with Clang, there are some array-out-of-bound
warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
library. With `-Werror` on, these warnings would stop gRPC from
compiling. This patch ignores such errors.


Diffs (updated)
-----

  3rdparty/Makefile.am 26e5d55561731ff03639df31562bb835d9687339 


Diff: https://reviews.apache.org/r/68114/diff/2/

Changes: https://reviews.apache.org/r/68114/diff/1-2/


Testing
-------

`sudo make check` with clang on ubuntu 16.04, which triggers the warnings.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message