mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 68114: Fixed gRPC compilation with Clang when building Mesos.
Date Wed, 01 Aug 2018 21:49:52 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 1, 2018, 9:49 p.m.)

Review request for mesos and Benjamin Bannier.


Addressed Benjamin's comments.

Summary (updated)

Fixed gRPC compilation with Clang when building Mesos.

Bugs: MESOS-8395

Repository: mesos


When compiling gRPC with Clang, there are some array-out-of-bound
warnings due to the use of GLIBC's `__strcmp_cg` macro in the c-ares
library. With `-Werror` on, these warnings would stop gRPC from
compiling. This patch ignores such errors.

Diffs (updated)

  3rdparty/ 26e5d55561731ff03639df31562bb835d9687339 




`sudo make check` with clang on ubuntu 16.04, which triggers the warnings.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message