mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68151: Avoided some expensive copies in the allocator.
Date Wed, 01 Aug 2018 20:51:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68151/#review206759
-----------------------------------------------------------


Ship it!





src/master/allocator/mesos/hierarchical.cpp
Line 1732 (original), 1731 (patched)
<https://reviews.apache.org/r/68151/#comment289851>

    Maybe a CHECK_NOTNULL around the de-reference?


- Benjamin Mahler


On Aug. 1, 2018, 8:36 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68151/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2018, 8:36 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Avoided unnecessary copies from
> `sorter->allocation(string client)` calls.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 35992474eacb8b14ae57e1dc23307e1542f63cb5

> 
> 
> Diff: https://reviews.apache.org/r/68151/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message